-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner/core: fix the 'for update' condition for the point get query #11771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11771 +/- ##
===============================================
- Coverage 81.478% 81.4567% -0.0213%
===============================================
Files 434 434
Lines 93381 93274 -107
===============================================
- Hits 76085 75978 -107
- Misses 11858 11869 +11
+ Partials 5438 5427 -11 |
Codecov Report
@@ Coverage Diff @@
## master #11771 +/- ##
================================================
- Coverage 81.6663% 81.4358% -0.2306%
================================================
Files 435 434 -1
Lines 93964 93368 -596
================================================
- Hits 76737 76035 -702
- Misses 11789 11891 +102
- Partials 5438 5442 +4 |
jackysp
reviewed
Aug 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
coocood
reviewed
Aug 19, 2019
LGTM |
coocood
added
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Aug 19, 2019
coocood
approved these changes
Aug 19, 2019
coocood
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Aug 19, 2019
/run-all-tests |
cherry pick to release-3.0 in PR #11775 |
coocood
pushed a commit
that referenced
this pull request
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sig/planner
SIG: Planner
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/bugfix
This PR fixes a bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix bug introduced in #11715
Sometimes,
InTxn()
is not precise, so we should check bothInTxn()
andautocommit
What is changed and how it works?
The check condition is changed from
InTxn()
toIsAutocommit() || InTxn()
Check List
Tests
Related changes