-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix incorrect table name in explain information #11780
Conversation
6f12cc9
to
39aaf2e
Compare
Codecov Report
@@ Coverage Diff @@
## master #11780 +/- ##
===========================================
Coverage ? 81.4916%
===========================================
Files ? 434
Lines ? 93644
Branches ? 0
===========================================
Hits ? 76312
Misses ? 11872
Partials ? 5460 |
/run-all-tests |
/run-unit-test |
e41a810
to
e486b88
Compare
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
/run-all-tests |
What problem does this PR solve?
Fix #11782
What is changed and how it works?
Add necessary
TableAsName
field intoPhysicalTableScan
.For case 1, add it in
constructInnerIndexScanTask
.For case 2, add it in
convertToIndexScan
.For case 3, this case happens because we set
TableAsName
afterbuildDataSource
. In most cases it goes well, but when we need union scan, line 2348 will be triggered:The return value is
LogicalUnionScan
instead ofDataSource
, soTableAsName
will not be set in these lines ofbuildResultSetNode
:So we can pass
&x.AsName
intobuildDataSource
, and setTableAsName
in it.Check List
Tests
Side effects