expression: fix DIV with decimal type #11804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #11804 +/- ##
=========================================
Coverage 81.519% 81.519%
=========================================
Files 435 435
Lines 93891 93891
=========================================
Hits 76539 76539
Misses 11883 11883
Partials 5469 5469 |
qw4990
reviewed
Aug 21, 2019
qw4990
reviewed
Aug 21, 2019
wshwsh12
added
status/LGT2
|
/run-all-tests |
|
@Reminiscent merge failed. |
|
/run-auto-merge |
|
/run-all-tests |
|
cherry pick to release-2.1 in PR #11812 |
|
cherry pick to release-3.0 in PR #11813 |
zz-jason
pushed a commit
that referenced
this pull request
Aug 21, 2019
zz-jason
pushed a commit
that referenced
this pull request
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Closes: #11180
operator_div in mysql.
In TiDB, the division operator does not correctly resolve the case that an operand is an unsigned number.
What is changed and how it works?
When evaluating the expression of 'div with decimal type', it will check the operands first.
And do different things depend on whether either of the operands is unsigned.
Check List
Tests
add two test cases and pass all the tests