session: fix log slow log succ field #11867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zz-jason
reviewed
Aug 26, 2019
session/tidb.go
Outdated
| @@ -214,7 +214,7 @@ func runStmt(ctx context.Context, sctx sessionctx.Context, s sqlexec.Statement) | |||
| // If it is not a select statement, we record its slow log here, | |||
| // then it could include the transaction commit time. | |||
| if rs == nil { | |||
| s.(*executor.ExecStmt).LogSlowQuery(se.GetSessionVars().TxnCtx.StartTS, err != nil) | |||
| s.(*executor.ExecStmt).LogSlowQuery(se.GetSessionVars().TxnCtx.StartTS, err == nil) | |||
There was a problem hiding this comment.
It's hard to add UT to test this..., any suggestion？
There was a problem hiding this comment.
how about duplicated primary key error?
There was a problem hiding this comment.
? To test this problem, we need the slow log output and get the SQL corresponding slow log, then check the succ field.
The above method is hard to implement in UT.
Codecov Report
@@ Coverage Diff @@
## master #11867 +/- ##
===============================================
+ Coverage 81.2595% 81.4186% +0.159%
===============================================
Files 438 438
Lines 94635 94993 +358
===============================================
+ Hits 76900 77342 +442
+ Misses 12238 12174 -64
+ Partials 5497 5477 -20 |
|
/run-all-tests |
zz-jason
added
status/LGT2
|
cherry pick to release-2.1 in PR #11886 |
|
cherry pick to release-3.0 in PR #11887 |
sre-bot
added a commit
that referenced
this pull request
Aug 28, 2019
sre-bot
added a commit
that referenced
this pull request
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The
succfield in the slow log was wrong when logging slow log for DDL/DML andadmin show slow.What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release note
succfield in slow log andadmin show lowwas wrong.