Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: fix string to integer cast (#11295) #11892

Merged
merged 3 commits into from
Aug 28, 2019

Conversation

amyangfei
Copy link
Contributor

cherry-pick #11295 to release-2.1

@amyangfei
Copy link
Contributor Author

/run-all-tests

@amyangfei
Copy link
Contributor Author

/run-all-tests

@XuHuaiyu XuHuaiyu requested review from zz-jason and qw4990 August 28, 2019 02:05
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu added the status/can-merge Indicates a PR has been approved by a committer. label Aug 28, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 28, 2019

Sorry @XuHuaiyu, you don't have permission to trigger auto merge event on this branch.

@zz-jason zz-jason merged commit 456bbcc into pingcap:release-2.1 Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants