Faster Clone() in kv/key.go #11957
Merged
Faster Clone() in kv/key.go #11957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A simple benchmark for this change: DeepCopyBytes is the new one, test value is []byte("11111") |
Codecov Report
@@ Coverage Diff @@
## master #11957 +/- ##
================================================
- Coverage 81.6088% 81.2264% -0.3824%
================================================
Files 449 443 -6
Lines 96916 94921 -1995
================================================
- Hits 79092 77101 -1991
- Misses 12252 12334 +82
+ Partials 5572 5486 -86 |
|
@ZYunH Thanks for your contributing, please follow the Commit Message and Pull Request Style to reformat the PR title. |
jackysp
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new function use a predefined byte slice with length len(k) instead of use an undefined []byte(nil). The latter will grow in copy procession, and since Key is just an alias for []byte, so we can use len(k) instead of len([]byte(k)), the former is more readable.