-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fix the modify column
operation on the bit
column
#12008
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12008 +/- ##
===========================================
Coverage 81.4793% 81.4793%
===========================================
Files 447 447
Lines 95747 95747
===========================================
Hits 78014 78014
Misses 12172 12172
Partials 5561 5561 |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
@zimulala merge failed. |
/run-integration-common-test |
/run-common-test |
/run-integration-common-test |
/run-common-test |
/run-integration-common-test -tidb-test=pr/880 |
/run-all-tests |
/run-common-test |
cherry pick to release-3.0 in PR #12052 |
cherry pick to release-2.1 failed |
What does this mean? Will the fix be merged to 2.1? |
It seems that, not for sure, we failed to cherry-pick this commit to release-2.1. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @zimulala PTAL. |
/run-cherry-picker |
Signed-off-by: sre-bot <sre-bot@pingcap.com>
cherry pick to release-2.1 in PR #16312 |
What problem does this PR solve?
Before this PR:
Fix #11800
What is changed and how it works?
Add the
UnsignedFlag
tobit
likeadd column
when doingmodify column
.Check List
Tests
Related changes
Release note
modify column
operation on thebit
column.