Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: update parser for add where for show table region syntax #12015

Merged
merged 2 commits into from
Sep 4, 2019
Merged

parser: update parser for add where for show table region syntax #12015

merged 2 commits into from
Sep 4, 2019

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

Update parser to add where for show table region syntax.

Related parser PR: pingcap/parser#398

@sre-bot
Copy link
Contributor

sre-bot commented Sep 3, 2019

Thanks for your PR.
This PR will be closed by bot because you already had 2 opened PRs, close or merge them before submitting a new one.
#11702 , #11981

@sre-bot sre-bot closed this Sep 3, 2019
@codecov
Copy link

codecov bot commented Sep 3, 2019 •
edited
Loading

Codecov Report

Merging #12015 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12015   +/-   ##
===========================================
  Coverage   81.3627%   81.3627%           
===========================================
  Files           445        445           
  Lines         95481      95481           
===========================================
  Hits          77686      77686           
  Misses        12272      12272           
  Partials       5523       5523

winkyao
winkyao reviewed Sep 3, 2019
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520 crazycs520 reopened this Sep 4, 2019
AilinKid
AilinKid reviewed Sep 4, 2019
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tangenta
tangenta approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonng lonng merged commit 383c48a into pingcap:master Sep 4, 2019
crazycs520 added a commit to crazycs520/tidb that referenced this pull request Sep 10, 2019
@crazycs520
parser: update parser for add where for show table region syntax (pin…
0d4cfaa 
…gcap#12015)
crazycs520 added a commit to crazycs520/tidb that referenced this pull request Sep 10, 2019
@crazycs520
parser: update parser for add where for show table region syntax (pin…
eaaec18 
…gcap#12015)
zimulala pushed a commit that referenced this pull request Sep 10, 2019
@crazycs520 @zimulala
parser: update parser for add where for show table region syntax (#12015
603f0b9 
) (#12124)
jackysp pushed a commit that referenced this pull request Sep 11, 2019
@crazycs520 @jackysp
parser: update parser for add where for show table region syntax (#12015
da3ed88 
) (#12123)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid left review comments

@winkyao winkyao winkyao left review comments

@tangenta tangenta tangenta approved these changes

Assignees
No one assigned
Labels
component/parser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@crazycs520 @sre-bot @winkyao @AilinKid @tangenta @lonng