sessionctx/variable: refine slow log output by not print useless info #12016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12016 +/- ##
================================================
+ Coverage 81.2963% 81.4652% +0.1688%
================================================
Files 451 451
Lines 96671 97379 +708
================================================
+ Hits 78590 79330 +740
+ Misses 12445 12400 -45
- Partials 5636 5649 +13 |
|
Could we keep the |
|
@shenli, Of course, Done. |
|
@qw4990 PTAL |
lonng
previously approved these changes
Sep 9, 2019
zz-jason
reviewed
Sep 9, 2019
| SlowLogCopWaitP90, SlowLogSpaceMarkStr, logItems.CopTasks.P90WaitTime.Seconds(), | ||
| SlowLogCopWaitMax, SlowLogSpaceMarkStr, logItems.CopTasks.MaxWaitTime.Seconds(), | ||
| SlowLogCopWaitAddr, SlowLogSpaceMarkStr, logItems.CopTasks.MaxWaitAddress) + "\n") | ||
| if logItems.CopTasks.NumCopTasks > 0 { |
There was a problem hiding this comment.
if NumCopTasks == 1, we only need to print SlowLogCopProcAvg
There was a problem hiding this comment.
Cop_wait_avg, cop_proc_addr also need?
done.
zz-jason
added
needs-cherry-pick-2.1
status/LGT2
crazycs520
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for #12094 |
|
cherry pick to release-3.0 in PR #12144 |
|
cherry pick to release-2.1 failed |
sre-bot
added a commit
that referenced
this pull request
Sep 11, 2019
|
It seems that, not for sure, we failed to cherry-pick this commit to release-2.1. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @crazycs520 PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works
No need to print cop info when there is no cop task.
eg:
As you can see,
Num_cop_tasksis 0, then the cop log is redundant.