-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: choose TableScan when use an empty index hint #12037
Merged
Merged
Changes from 8 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
05d95ff
choose TableScan when use an empty index hint
francis0407 aa2d13a
remove unused blank line
francis0407 025f731
remove ignore case
francis0407 7245bb8
consider comment style hint
francis0407 791a744
fix code style
francis0407 021a64b
fix code style
francis0407 00f8952
address comment
francis0407 bc06b14
Merge branch 'master' into use_index
francis0407 c64959b
address comment
francis0407 0fc9a6c
Merge branch 'use_index' of https://github.com/francis0407/tidb into …
francis0407 466d0d5
address comment
francis0407 034bd0e
minor change
francis0407 8cfdd0c
fix fmt
francis0407 cca636e
Merge branch 'master' into use_index
francis0407 3b9db23
Merge branch 'master' into use_index
sre-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -558,6 +558,15 @@ func (b *PlanBuilder) getPossibleAccessPaths(indexHints []*ast.IndexHint, tblInf | |
} | ||
|
||
hasScanHint = true | ||
if hint.IndexNames == nil && hint.HintType != ast.HintIgnore { | ||
// If indexNames is nil, choose TablePath. | ||
// For example: `select a from t use index()`. | ||
if path := getTablePath(publicPaths); path != nil { | ||
hasUseOrForce = true | ||
path.forced = true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You need check whether is ignore or force. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed |
||
available = append(available, path) | ||
} | ||
} | ||
for _, idxName := range hint.IndexNames { | ||
path := getPathByIndexName(publicPaths, idxName, tblInfo) | ||
if path == nil { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding a comment? From MySQL document:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed