-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix scatter region timeout issues and "show processlist" display issues #12057
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12057 +/- ##
=========================================
Coverage 81.492% 81.492%
=========================================
Files 457 457
Lines 101448 101448
=========================================
Hits 82672 82672
Misses 12971 12971
Partials 5805 5805 |
PTAL @crazycs520 @bb7133 @winkyao |
func (e *SplitIndexRegionExec) Open(ctx context.Context) error { | ||
return e.splitIndexRegion(ctx) | ||
func (e *SplitIndexRegionExec) Open(ctx context.Context) (err error) { | ||
e.splitIdxKeys, err = e.getSplitIdxKeys() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why moving getSplitIdxKeys()
to Open
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we do some checks in getSplitIdxKeys
, if put it to Next
some test cases will be failed and I think best to put it before Next
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
Related PR #6861 |
What problem does this PR solve?
Fix a single scatter region timeout does not exit
When processing "split table/index", the result of executing "show processlist" is as follows:
What is changed and how it works?
Add a check when encounter timeout error. And update logs.
Put the operations of splitting and scattering region into
Next
. After the PR:Check List
Tests