planner: add IGNORE_INDEX hint #12059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzmhhh123
reviewed
Sep 9, 2019
| @@ -1972,7 +1974,7 @@ func (b *PlanBuilder) pushTableHints(hints []*ast.TableOptimizerHint, nodeType n | |||
| preferAggType |= preferHashAgg | |||
| case HintStreamAgg: | |||
| preferAggType |= preferStreamAgg | |||
| case HintIndex: | |||
| case HintUseIndex: | |||
There was a problem hiding this comment.
What will happen if using both ignore_index(t, idx_a) and use_index(t, idx_a) in a sql block?
There was a problem hiding this comment.
Do we need to add a test for it?
There was a problem hiding this comment.
Seems that we will ignore all indexes... I'll add test and fix it.
There was a problem hiding this comment.
now it works just like normal index hint. Added some tests, you can check it out.
Codecov Report
@@ Coverage Diff @@
## master #12059 +/- ##
===========================================
Coverage 81.6305% 81.6305%
===========================================
Files 453 453
Lines 98370 98370
===========================================
Hits 80300 80300
Misses 12413 12413
Partials 5657 5657 |
|
Add some tests and resolved conflict, PTAL. @lzmhhh123 @lamxTyler |
|
/run-all-tests |
foreyes
force-pushed
the
dev/add_ignore_index_hint
branch
from
62d5096
to
f97ff2b
Compare
|
/run-all-tests |
lzmhhh123
approved these changes
Sep 12, 2019
lzmhhh123
added
status/all tests passed
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
add
IGNORE_INDEXhint and changeINDEXintoUSE_INDEXhint.What is changed and how it works?
Just handle
hintIgnoreIndexas whathintIndexdo.Check List
Tests
Code changes
Side effects
Related changes
Release note