*: refactoring the code of batchChecker #12099
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
batchChecker is difficult to maintain, we should get rid of it.
In this commit I catch the BatchGet result into the snapshot, in this way we can
achieve the same goal as the batchChecker
What problem does this PR solve?
The
batchChecker
is difficult to maintain. It's fragile, full of bugs, we should get rid of it.Expect:
Get:
What is changed and how it works?
The first step: do not use it.
The second step: clean up the code.
In this commit, I re-implement the
insert ... on duplicate key update ...
without using thebatchChecker
.And I also implement a cache mechanism in the snapshot and the BatchGet API, so the performance should not change.
Check List
Tests
Side effects
Related changes
Release note
Fix bugs of
insert ... on duplicate update
on the partitioned table