Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: generate index path as candidate when it is a single scan (#12022) #12112

Merged
merged 9 commits into from
Sep 10, 2019

Conversation

francis0407
Copy link
Member

What problem does this PR solve?

cherry pick #12022

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francis0407
Copy link
Member Author

/run-all-tests

@francis0407
Copy link
Member Author

/run-common-test

@zz-jason
Copy link
Member

/run-all-tests

@zz-jason zz-jason changed the title planner: generate index path as candidate when it is a single scan planner: generate index path as candidate when it is a single scan (#12022) Sep 10, 2019
@francis0407 francis0407 added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 10, 2019
@winoros
Copy link
Member

winoros commented Sep 10, 2019

/run-common-test

3 similar comments
@francis0407
Copy link
Member Author

/run-common-test

@zz-jason
Copy link
Member

/run-common-test

@zyxbest
Copy link
Contributor

zyxbest commented Sep 10, 2019

/run-common-test

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@francis0407 francis0407 added the status/can-merge Indicates a PR has been approved by a committer. label Sep 10, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 10, 2019

Sorry @francis0407, you don't have permission to trigger auto merge event on this branch.

@francis0407 francis0407 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants