planner/core: fix point-get db privilege check #12268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #12268 +/- ##
===========================================
Coverage 81.1786% 81.1786%
===========================================
Files 454 454
Lines 99079 99079
===========================================
Hits 80431 80431
Misses 12880 12880
Partials 5768 5768 |
jackysp
added
status/can-merge
|
/run-all-tests |
|
cherry pick to release-3.0 failed |
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.1 failed |
This was referenced Sep 24, 2019
sre-bot
pushed a commit
that referenced
this pull request
Sep 24, 2019
sre-bot
pushed a commit
that referenced
this pull request
Sep 24, 2019
|
@lysu This PR has been labeled with |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Nov 6, 2019
sre-bot
added a commit
that referenced
this pull request
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
current point-get code path checks db privilege by current db and miss check
db1privilege for query usingdb.tbl1.and see more detail in test case.
What is changed and how it works?
check privilege using db in ast tree if it exists.
Check List
Tests
Code changes
Side effects
Related changes
Release note
This change is