planner: fix some window specific check bug for window function. #12394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzmhhh123
added
type/bugfix
SunRunAway
added
status/can-merge
|
Your auto merge job has been accepted, waiting for 12375 |
|
/run-all-tests |
|
@lzmhhh123 merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for 12376 |
|
/run-all-tests |
|
/run-unit-test |
Codecov Report
@@ Coverage Diff @@
## master #12394 +/- ##
===========================================
Coverage 80.0668% 80.0668%
===========================================
Files 461 461
Lines 103180 103180
===========================================
Hits 82613 82613
Misses 14746 14746
Partials 5821 5821 |
|
/run-all-tests |
|
@lzmhhh123 merge failed. |
|
/merge |
|
/run-all-tests |
|
cherry pick to release-3.0 failed |
|
cherry pick to release-3.1 failed |
lzmhhh123
added a commit
to lzmhhh123/tidb
that referenced
this pull request
Sep 26, 2019
lzmhhh123
added a commit
to lzmhhh123/tidb
that referenced
this pull request
Sep 26, 2019
sre-bot
pushed a commit
that referenced
this pull request
Oct 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #12353
What is changed and how it works?
add some check for the situation.
Check List
Tests
Side effects
Related changes