Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mocktikv: fix data race in mocktikv split #12414

Merged
merged 2 commits into from
Oct 11, 2019
Merged

mocktikv: fix data race in mocktikv split #12414

merged 2 commits into from
Oct 11, 2019

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Sep 26, 2019

What problem does this PR solve?

fixes #12363

What is changed and how it works?

#12363 (comment)

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • change test

Side effects

  • n/a

Related changes

  • n/a

This change is Reviewable

@codecov
Copy link

codecov bot commented Sep 26, 2019

Codecov Report

Merging #12414 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12414   +/-   ##
===========================================
  Coverage   80.3233%   80.3233%           
===========================================
  Files           460        460           
  Lines        106187     106187           
===========================================
  Hits          85293      85293           
  Misses        14791      14791           
  Partials       6103       6103

@coocood
Copy link
Member

coocood commented Sep 27, 2019

LGTM

Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520 crazycs520 added the status/can-merge Indicates a PR has been approved by a committer. label Oct 11, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 11, 2019

/run-all-tests

@sre-bot sre-bot merged commit ea6d508 into pingcap:master Oct 11, 2019
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
crazycs520 pushed a commit to crazycs520/tidb that referenced this pull request Feb 21, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 failed

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 2, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #19711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data race in mocktikv
6 participants