Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: update's select should not change the output columns (#12476) #12483

Merged
merged 2 commits into from
Sep 29, 2019
Merged

planner: update's select should not change the output columns (#12476) #12483

merged 2 commits into from
Sep 29, 2019

Conversation

winoros
Copy link
Member

@winoros winoros commented Sep 29, 2019

cherry-pick #12476

qw4990
qw4990 reviewed Sep 29, 2019
View reviewed changes
tools/check/go.mod Outdated Show resolved Hide resolved
@winkyao
Copy link
Contributor

winkyao commented Sep 29, 2019

/rebuild

@winoros
Copy link
Member Author

winoros commented Sep 29, 2019

/run-all-tests

@winkyao winkyao added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Sep 29, 2019
@qw4990
Copy link
Contributor

qw4990 commented Sep 29, 2019

/run-unit-test

eurekaka
eurekaka reviewed Sep 29, 2019
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 29, 2019
winkyao
winkyao approved these changes Sep 29, 2019
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao winkyao merged commit 694e086 into pingcap:release-3.0 Sep 29, 2019
@winoros winoros deleted the pick branch September 29, 2019 12:37
winoros added a commit to winoros/tidb that referenced this pull request Nov 8, 2019
@winoros
planner: update's select should not change the output columns (pingca…
4b1074c 
…p#12476) (pingcap#12483)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@eurekaka eurekaka eurekaka left review comments

@winkyao winkyao winkyao approved these changes

Assignees
No one assigned
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/planner SIG: Planner status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@winoros @winkyao @qw4990 @eurekaka