Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: fix panic when check null rejection for from_unixtime (#12413) #12552

Merged
merged 4 commits into from
Oct 10, 2019
Merged

*: fix panic when check null rejection for from_unixtime (#12413) #12552

merged 4 commits into from
Oct 10, 2019

Conversation

zz-jason
Copy link
Member

@zz-jason zz-jason commented Oct 8, 2019

Cherry pick #12413 to release-3.1. Original PR description:

Signed-off-by: Zhang Jian zjsariel@gmail.com

What problem does this PR solve?

fix #12385

What is changed and how it works?

check whether the argument is NULL before using the value pointer.

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Related changes

  • Need to cherry-pick to the release branch

Release note

fix the panic when check null rejection for `from_unixtime`.

SunRunAway
SunRunAway reviewed Oct 9, 2019
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 9, 2019
XuHuaiyu
XuHuaiyu reviewed Oct 9, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XuHuaiyu
XuHuaiyu previously approved these changes Oct 9, 2019
View reviewed changes
@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 9, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 9, 2019

Your auto merge job has been accepted, waiting for 12558, 12564, 12551

@zz-jason zz-jason removed the request for review from qw4990 October 9, 2019 08:45
@zz-jason
Copy link
Member Author

zz-jason commented Oct 9, 2019

/rebuild

@sre-bot
Copy link
Contributor

sre-bot commented Oct 9, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Oct 9, 2019

@zz-jason merge failed.

@zz-jason zz-jason requested a review from XuHuaiyu October 10, 2019 02:42
@zz-jason zz-jason merged commit 02f791b into pingcap:release-3.1 Oct 10, 2019
@zz-jason zz-jason deleted the cherrypick/3.1/fix-null-rejective branch October 10, 2019 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway SunRunAway left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zz-jason @sre-bot @SunRunAway @XuHuaiyu