Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix unexpected behavior of UPDATE #12597

Merged
merged 2 commits into from
Oct 10, 2019

Conversation

winoros
Copy link
Member

@winoros winoros commented Oct 10, 2019

What problem does this PR solve?

The bug is introduced by the cherry-picked commit.
Master has some other changes to make that commit work properly. But in 3.0 branch, there's no such changes so it would get wrong result.

What is changed and how it works?

In master, we removed the TblID2Handle map in schema.
So in 3.0 we still need to maintain it.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

@winoros winoros added sig/planner SIG: Planner type/bugfix This PR fixes a bug. labels Oct 10, 2019
@eurekaka
Copy link
Contributor

/run-all-tests tidb-test=release-3.0 pd=release-3.0 tikv=release-3.0

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 10, 2019
@eurekaka eurekaka requested review from zz-jason and alivxxx October 10, 2019 09:12
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 10, 2019
@zz-jason zz-jason merged commit 32bd4a7 into pingcap:release-3.0 Oct 10, 2019
eurekaka pushed a commit to eurekaka/tidb that referenced this pull request Oct 10, 2019
@winoros winoros deleted the 3.0-fix branch November 4, 2019 05:11
winoros added a commit to winoros/tidb that referenced this pull request Nov 4, 2019
winoros added a commit to winoros/tidb that referenced this pull request Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants