-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Support required rows rows for arrow decode format. #12613
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12613 +/- ##
================================================
- Coverage 80.0972% 80.0927% -0.0045%
================================================
Files 468 468
Lines 110814 110794 -20
================================================
- Hits 88759 88738 -21
- Misses 15200 15201 +1
Partials 6855 6855 |
|
53dd3af
to
cbe252f
Compare
/run-all-tests |
/run-mybatis-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider rearrange our benchmark targeting SelectResponse
, writing two benchmark functions BenchmarkSelectResponseArror_BigResponse
and BenchmarkSelectResponseArror_SmallResponse
is ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Your auto merge job has been accepted, waiting for 12669 |
/run-all-tests |
What problem does this PR solve?
When using arrow format to decode data, it appends all data into one chunk.
It may cause that a chunk save too many things.
In this pr, support required rows for arrow decode format.
What is changed and how it works?
Add a struct
ArrowDecoder
to deal with the detail when append required rows to the returned chunk.chunk
in the struct. (Memory reuse, really fast)Check List
Tests
Code changes
Side effects
Related changes
Release note
Benchmark
TPCH 50G