Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: fix upgrade logic when bootstrap #12827

Merged
merged 6 commits into from
Nov 9, 2019
Merged

Conversation

tangenta
Copy link
Contributor

What problem does this PR solve?

Fix upgrade logic when bootstrap.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

Release note

  • Fix upgrade logic when bootstrap.

@codecov
Copy link

codecov bot commented Oct 19, 2019

Codecov Report

Merging #12827 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12827   +/-   ##
===========================================
  Coverage   80.1797%   80.1797%           
===========================================
  Files           469        469           
  Lines        111800     111800           
===========================================
  Hits          89641      89641           
  Misses        15252      15252           
  Partials       6907       6907

session/bootstrap.go Outdated Show resolved Hide resolved
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 21, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Nov 9, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 9, 2019

Your auto merge job has been accepted, waiting for 13014

@zz-jason zz-jason removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 9, 2019
@zz-jason
Copy link
Member

zz-jason commented Nov 9, 2019

@tangenta do we need to cherry pick this commit to release branches?

@sre-bot
Copy link
Contributor

sre-bot commented Nov 9, 2019

/run-all-tests

@sre-bot sre-bot merged commit b7eddbf into pingcap:master Nov 9, 2019
@tangenta
Copy link
Contributor Author

@tangenta do we need to cherry pick this commit to release branches?

@zz-jason I will cherry pick it later.

@tangenta
Copy link
Contributor Author

There is no version32 on the branch release-2.1, so I don't cherry-pick it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/session status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants