Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: wait all fetchChildData exiting in HashAggExec.Close (#12930) #12961

Merged
merged 3 commits into from
Oct 29, 2019
Merged

executor: wait all fetchChildData exiting in HashAggExec.Close (#12930) #12961

merged 3 commits into from
Oct 29, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Oct 28, 2019

cherry-pick #12930 to release-3.0

What problem does this PR solve?

Fix #12929

What is changed and how it works?

Wait all fetchChildData exiting in HashAggExec.Close.

Check List

Tests

  • None

Code changes

  • None

Side effects

  • None

Related changes

  • None

Release note

  • None

@sre-bot
Copy link
Contributor Author

sre-bot commented Oct 28, 2019

/run-all-tests

@sre-bot sre-bot mentioned this pull request Oct 28, 2019
Merged
@sre-bot sre-bot added sig/execution SIG execution type/3.0 cherry-pick type/bugfix This PR fixes a bug. labels Oct 28, 2019
alivxxx
alivxxx previously approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx dismissed their stale review October 28, 2019 07:16

Only one LGTM

XuHuaiyu
XuHuaiyu approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Oct 28, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Oct 28, 2019

/run-all-tests

@francis0407
Copy link
Member

/merge

@glorv
Copy link
Contributor

glorv commented Oct 29, 2019

/run-all-tests

@glorv
Copy link
Contributor

glorv commented Oct 29, 2019

/build

@sre-bot sre-bot merged commit e48693b into pingcap:release-3.0 Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@alivxxx alivxxx alivxxx left review comments

@qw4990 qw4990 Awaiting requested review from qw4990

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

Assignees
No one assigned
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sre-bot @francis0407 @glorv @XuHuaiyu @alivxxx @zz-jason @SunRunAway