planner: correct block offset for table as names #12996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12996 +/- ##
=========================================
Coverage 80.633% 80.633%
=========================================
Files 469 469
Lines 113931 113931
=========================================
Hits 91866 91866
Misses 15077 15077
Partials 6988 6988 |
winoros
reviewed
Oct 30, 2019
|
@winoros In this case, I think we can support it and it matches what we think it should do. |
lzmhhh123
reviewed
Nov 11, 2019
winoros
approved these changes
Nov 11, 2019
alivxxx
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for 13360 |
alivxxx
added
status/LGT2
|
/run-all-tests |
|
cherry pick to release-3.1 failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Hint in
select /*+ SM_JOIN(@sel_1 t1@sel_1, t2@sel_1) */ * from (select * from t) t1, t t2 where t1.b = t2.b;does not take effects.It does not take effects because currently planner thinks
t1belongs tosel_2, so it cannot find a matching table.What is changed and how it works?
Specially handle the case of select block as names so that the
as namesshould belong to its surrounding select block, not the sub-query.Check List
Tests
Code changes
Side effects
Related changes
Release note