Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl, executor: limit the length of the index name when executing "create table" #13016

Merged
merged 2 commits into from
Nov 9, 2019

Conversation

zimulala
Copy link
Contributor

What problem does this PR solve?

We don't limit the length of the index name when executing the operation of create table.

What is changed and how it works?

Check the index name's length when calling buildIndexInfo.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Limit the length of the index name when executing "create table"

@codecov
Copy link

codecov bot commented Oct 30, 2019

Codecov Report

Merging #13016 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13016   +/-   ##
===========================================
  Coverage   80.2414%   80.2414%           
===========================================
  Files           469        469           
  Lines        112078     112078           
===========================================
  Hits          89933      89933           
  Misses        15237      15237           
  Partials       6908       6908

Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 1, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 9, 2019
@zz-jason zz-jason requested review from winkyao and bb7133 November 9, 2019 02:53
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added status/LGT3 The PR has already had 3 LGTM. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Nov 9, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 9, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 9, 2019

cherry pick to release-3.1 in PR #13309

@sre-bot
Copy link
Contributor

sre-bot commented Nov 9, 2019

cherry pick to release-3.0 in PR #13310

@sre-bot
Copy link
Contributor

sre-bot commented Nov 9, 2019

cherry pick to release-2.1 in PR #13311

@zimulala zimulala deleted the fix-idx-name branch November 14, 2019 06:58
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. type/bugfix This PR fixes a bug. type/compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants