*: rename Arrow to Chunk #13060
Merged
*: rename Arrow to Chunk #13060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wshwsh12
force-pushed
the
rename_arrow_to_chunk
branch
from
2c3a68c
to
23ca212
Compare
Codecov Report
@@ Coverage Diff @@
## master #13060 +/- ##
================================================
- Coverage 80.2132% 80.1046% -0.1086%
================================================
Files 469 468 -1
Lines 111534 110840 -694
================================================
- Hits 89465 88788 -677
- Misses 15163 15197 +34
+ Partials 6906 6855 -51 |
|
/run-all-tests |
XuHuaiyu
reviewed
Nov 1, 2019
|
PTAL @zz-jason |
wshwsh12
force-pushed
the
rename_arrow_to_chunk
branch
2 times, most recently
from
4aaafaa
to
2a33082
Compare
wshwsh12
force-pushed
the
rename_arrow_to_chunk
branch
from
2a33082
to
0814dfe
Compare
|
/run-all-tests |
zz-jason
reviewed
Nov 6, 2019
config/config.toml.example
Outdated
| # Enable chunk encoded data. | ||
| enable-arrow = true | ||
| # Enable chunk encoded data for coprocessor requests. | ||
| enable-chunk-response = true |
There was a problem hiding this comment.
how about s/enable-chunk-response/enable-chunk-rpc/?
distsql/distsql.go
Outdated
| } else { | ||
| dagReq.EncodeType = tipb.EncodeType_TypeDefault | ||
| } | ||
| } | ||
|
|
||
| func enableTypeArrow(ctx sessionctx.Context) bool { | ||
| if !ctx.GetSessionVars().EnableArrow { | ||
| func enableTypeChunk(ctx sessionctx.Context) bool { |
There was a problem hiding this comment.
how about s/enableTypeChunk/canUseChunkRPC/
sessionctx/variable/tidb_vars.go
Outdated
| // tidb_enable_arrow enables TiDB to use Chunk format for coprocessor requests. | ||
| TiDBEnableArrow = "tidb_enable_arrow" | ||
| // tidb_enable_chunk_response enables TiDB to use Chunk format for coprocessor requests. | ||
| TiDBEnableChunkResponse = "tidb_enable_chunk_response" |
Signed-off-by: wshwsh12 <793703860@qq.com>
Signed-off-by: wshwsh12 <793703860@qq.com>
Signed-off-by: wshwsh12 <793703860@qq.com>
zz-jason
added
status/can-merge
|
Your auto merge job has been accepted, waiting for 13169 |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In tidb, use
arrowinstead ofchunkin some places. This can be misleading.What is changed and how it works?
In this pr, I change all
arrowtochunk.Check List
Tests
Code changes
Side effects
Related changes
Release note
Related PR
pingcap/tipb#151