Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infoschema/slow_query: add more field in slow_query table (#13007) #13072

Merged
merged 5 commits into from
Nov 5, 2019
Merged

infoschema/slow_query: add more field in slow_query table (#13007) #13072

merged 5 commits into from
Nov 5, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Nov 1, 2019

cherry-pick #13007 to release-3.0

What problem does this PR solve?

  • add more field in slow_query table.
    • Prewrite_time
    • Commit_time
    • Get_commit_ts_time
    • Commit_backoff_time
    • Backoff_types
    • Resolve_lock_time
    • Local_latch_wait_time
    • Write_keys
    • Write_size
    • Prewrite_region
    • Txn_retry

What is changed and how it works?

  • infoschema/slow_query

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Add more fields in slow_query table to improve the usability of slow query:
    • A

@sre-bot
Copy link
Contributor Author

sre-bot commented Nov 1, 2019

/run-all-tests

@sre-bot sre-bot mentioned this pull request Nov 1, 2019
Merged
zimulala
zimulala reviewed Nov 1, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zimulala
zimulala reviewed Nov 5, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bb7133
bb7133 reviewed Nov 5, 2019
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. labels Nov 5, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Nov 5, 2019

Sorry @bb7133, you don't have permission to trigger auto merge event on this branch.

AilinKid
AilinKid approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Nov 5, 2019

Sorry @crazycs520, you don't have permission to trigger auto merge event on this branch.

@zimulala zimulala merged commit fa90d57 into pingcap:release-3.0 Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@bb7133 bb7133 bb7133 left review comments

@AilinKid AilinKid AilinKid approved these changes

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sre-bot @crazycs520 @bb7133 @zimulala @AilinKid