Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: record previous statement when commit is slow (#11908) (#12180) #13232

Merged
merged 3 commits into from
Nov 7, 2019

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Nov 7, 2019

What problem does this PR solve?

Cherry pick #12180 to release 3.1
Conflicts:
session/tidb.go
sessionctx/variable/session.go

What is changed and how it works?

…gcap#12180)

Conflicts:
session/tidb.go
sessionctx/variable/session.go
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@jackysp jackysp requested review from crazycs520 and lysu November 7, 2019 03:31
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added type/3.1 cherry-pick type/enhancement The issue or PR belongs to an enhancement. labels Nov 7, 2019
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520
Copy link
Contributor

/run-all-tests

@lysu lysu added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 7, 2019
@jackysp jackysp added the status/can-merge Indicates a PR has been approved by a committer. label Nov 7, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 7, 2019

/run-all-tests

@sre-bot sre-bot merged commit d2ec98f into pingcap:release-3.1 Nov 7, 2019
@jackysp jackysp deleted the prev_stmt_3.1 branch February 27, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants