Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner/cascades: add transformation rule TransformLimitToTopN #13288

Merged
merged 3 commits into from
Nov 9, 2019

Conversation

francis0407
Copy link
Member

What problem does this PR solve?

This PR adds transformation rule TransformLimitToTopN, which transforms Limit + Sort to TopN.

What is changed and how it works?

Check List

Tests

  • Unit test

@codecov
Copy link

codecov bot commented Nov 8, 2019

Codecov Report

Merging #13288 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13288   +/-   ##
===========================================
  Coverage   80.1925%   80.1925%           
===========================================
  Files           469        469           
  Lines        111862     111862           
===========================================
  Hits          89705      89705           
  Misses        15248      15248           
  Partials       6909       6909

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francis0407 francis0407 added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 8, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 9, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 9, 2019

Your auto merge job has been accepted, waiting for 12488, 13159, 12772, 13206, 13260

@sre-bot
Copy link
Contributor

sre-bot commented Nov 9, 2019

/run-all-tests

@sre-bot sre-bot merged commit 30d9957 into pingcap:master Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/new-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants