session,store/tikv: make CI more stable #13303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make TestBatchResolveLocks more stable make TestErrorRollback faster
|
PTAL @SunRunAway |
Codecov Report
@@ Coverage Diff @@
## master #13303 +/- ##
===========================================
Coverage 80.1529% 80.1529%
===========================================
Files 469 469
Lines 112042 112042
===========================================
Hits 89805 89805
Misses 15291 15291
Partials 6946 6946 |
bb7133
reviewed
Nov 8, 2019
| @@ -151,7 +151,7 @@ func (s *testSessionSuite) TestErrorRollback(c *C) { | |||
| var wg sync.WaitGroup | |||
| cnt := 4 | |||
| wg.Add(cnt) | |||
| num := 100 | |||
| num := 20 | |||
There was a problem hiding this comment.
Is it OK to decrease the tested number?
Would you please give some explains why this test become slower since the related PR is merged
There was a problem hiding this comment.
Is it OK to decrease the tested number?
I guess so, at lease the change doesn't affect the correctness.
The ResolveLocks function is more sensitivity than before, in a heavy write conflict sense the contention increase.
|
LGTM |
sykp241095
approved these changes
Nov 9, 2019
sykp241095
added
the
status/can-merge
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
@tiancaiamao merge failed. |
|
/run-unit-test |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
make TestBatchResolveLocks more stable make TestErrorRollback faster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
make
TestBatchResolveLocksmore stablemake
TestErrorRollbackfasterFix #13281
What is changed and how it works?
After #13123, TestErrorRollback runs slower than before in the race test.
Increase TTL for
TestBatchResolveLocksto make it more stable.Check List
Tests