Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinHexIntArgSig #13330

Merged
merged 2 commits into from
Nov 11, 2019
Merged

expression: implement vectorized evaluation for builtinHexIntArgSig #13330

merged 2 commits into from
Nov 11, 2019

Conversation

js00070
Copy link
Contributor

@js00070 js00070 commented Nov 10, 2019

PCP #12106

What problem does this PR solve?

implement vectorized evaluation for builtinHexIntArgSig from #12106

What is changed and how it works?

about 6% faster

BenchmarkVectorizedBuiltinStringFunc/builtinHexIntArgSig-VecBuiltinFunc-12                  6212            184285 ns/op           32673 B/op       2449 allocs/op
BenchmarkVectorizedBuiltinStringFunc/builtinHexIntArgSig-NonVecBuiltinFunc-12               5490            196329 ns/op           32673 B/op       2449 allocs/op

Check List

Tests

  • Unit test

@js00070 js00070 requested a review from a team as a code owner November 10, 2019 14:58
@ghost ghost requested review from wshwsh12 and XuHuaiyu November 10, 2019 14:58
@sre-bot
Copy link
Contributor

sre-bot commented Nov 10, 2019

Thanks for your contribution. If your PR get merged, you will be rewarded 50 points.

@ghost ghost removed their request for review November 10, 2019 14:58
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 10, 2019
@codecov
Copy link

codecov bot commented Nov 10, 2019 •
edited
Loading

Codecov Report

Merging #13330 into master will decrease coverage by 0.0348%.
The diff coverage is 75%.

@@               Coverage Diff                @@
##             master     #13330        +/-   ##
================================================
- Coverage   80.1654%   80.1306%   -0.0349%     
================================================
  Files           469        469                
  Lines        112289     112077       -212     
================================================
- Hits          90017      89808       -209     
- Misses        15301      15318        +17     
+ Partials       6971       6951        -20

@b41sh
Copy link
Member

b41sh commented Nov 11, 2019

LGTM

Reminiscent
Reminiscent approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reminiscent Reminiscent added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Nov 11, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 11, 2019

Your auto merge job has been accepted, waiting for 13269, 13316

@sre-bot
Copy link
Contributor

sre-bot commented Nov 11, 2019

/run-all-tests

@sre-bot sre-bot merged commit 30da446 into pingcap:master Nov 11, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 11, 2019

@js00070 complete task #12106 and get 50 score, currerent score 250.

XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@js00070 @XiaTianliang
expression: implement vectorized evaluation for builtinHexIntArgSig (…
8fb1093 
…pingcap#13330)
@js00070 js00070 deleted the HexIntArg branch February 1, 2020 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@js00070 @sre-bot @b41sh @Reminiscent @wshwsh12