Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinSysDateWithFspSig #13332

Merged
merged 18 commits into from
Nov 16, 2019
Merged

expression: implement vectorized evaluation for builtinSysDateWithFspSig #13332

merged 18 commits into from
Nov 16, 2019

Conversation

ekalinin
Copy link
Contributor

PCP #12101

What problem does this PR solve?

This PR implements vectorized builtinSysDateWithFspSig

What is changed and how it works?

➜ make vectorized-bench VB_FILE=Time VB_FUNC=builtinSysDateWithFspSig
cd ./expression && \
	go test -v -benchmem \
		-bench=BenchmarkVectorizedBuiltinTimeFunc \
		-run=BenchmarkVectorizedBuiltinTimeFunc \
		-args "builtinSysDateWithFspSig"
goos: linux
goarch: amd64
pkg: github.com/pingcap/tidb/expression
BenchmarkVectorizedBuiltinTimeFuncGenerated-12    	1000000000	         0.00831 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinSysDateWithFspSig-VecBuiltinFunc-12         	    9387	    106730 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinSysDateWithFspSig-NonVecBuiltinFunc-12      	    6468	    191931 ns/op	       0 B/op	       0 allocs/op
PASS
ok  	github.com/pingcap/tidb/expression	2.351s

Check List

Tests

  • Unit test
  • Integration test

@ekalinin ekalinin requested a review from a team as a code owner November 10, 2019 17:05
@sre-bot
Copy link
Contributor

sre-bot commented Nov 10, 2019

Thanks for your contribution. If your PR get merged, you will be rewarded 50 points.

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 10, 2019
@ghost ghost requested review from wshwsh12 and XuHuaiyu and removed request for a team November 10, 2019 17:05
@codecov
Copy link

codecov bot commented Nov 10, 2019 •
edited
Loading

Codecov Report

Merging #13332 into master will increase coverage by 0.1166%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #13332        +/-   ##
================================================
+ Coverage   80.4631%   80.5797%   +0.1166%     
================================================
  Files           472        469         -3     
  Lines        115177     114391       -786     
================================================
- Hits          92675      92176       -499     
+ Misses        15277      15202        -75     
+ Partials       7225       7013       -212

@zyxbest
Copy link
Contributor

zyxbest commented Nov 11, 2019

/build

@ekalinin
Copy link
Contributor Author

/run-all-tests

XuHuaiyu
XuHuaiyu reviewed Nov 11, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/LGT1 Indicates that a PR has LGTM 1. status/ReqChange labels Nov 12, 2019
qw4990
qw4990 approved these changes Nov 16, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. status/ReqChange labels Nov 16, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 16, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 16, 2019

@ekalinin merge failed.

@qw4990
Copy link
Contributor

qw4990 commented Nov 16, 2019

/run-integration-copr-test

@qw4990 qw4990 merged commit 77d189b into pingcap:master Nov 16, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 16, 2019

@ekalinin complete task #12101 and get 50 score, currerent score 500.

@ekalinin ekalinin deleted the vec-builtinSysDateWithFspSig branch November 17, 2019 20:06
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@ekalinin @XiaTianliang
expression: implement vectorized evaluation for builtinSysDateWithFsp…
7a3ebc0 
…Sig (pingcap#13332)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ekalinin @sre-bot @zyxbest @qw4990 @XuHuaiyu @wshwsh12 @zz-jason