Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: generate big real numbers when testing #13338

Merged
merged 6 commits into from
Nov 11, 2019

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Nov 11, 2019

What problem does this PR solve?

Generate big real numbers when testing.

Check List

Tests

  • Unit test

@qw4990 qw4990 requested a review from a team as a code owner November 11, 2019 05:19
@ghost ghost requested review from SunRunAway and XuHuaiyu and removed request for a team November 11, 2019 05:19
@codecov
Copy link

codecov bot commented Nov 11, 2019

Codecov Report

Merging #13338 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13338   +/-   ##
===========================================
  Coverage   80.2553%   80.2553%           
===========================================
  Files           469        469           
  Lines        112547     112547           
===========================================
  Hits          90325      90325           
  Misses        15263      15263           
  Partials       6959       6959

@qw4990
Copy link
Contributor Author

qw4990 commented Nov 11, 2019

/run-all-tests

Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reminiscent Reminiscent added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 11, 2019
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway
Copy link
Contributor

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 11, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 11, 2019

Your auto merge job has been accepted, waiting for 13353, 13323

@sre-bot
Copy link
Contributor

sre-bot commented Nov 11, 2019

/run-all-tests

@sre-bot sre-bot merged commit 6f50566 into pingcap:master Nov 11, 2019
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression component/test status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants