Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: check table name length when rename table #13339

Merged
merged 2 commits into from
Nov 11, 2019
Merged

ddl: check table name length when rename table #13339

merged 2 commits into from
Nov 11, 2019

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve? 

create table t (a int,b int);
-- below sql should be error, but will execute successful before.
rename table t to txxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx;
(1059, u"Identifier name 'txxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx' is too long")

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Fix the issue that the rename table ddl should check the new table name length.

@crazycs520 crazycs520 added status/DNM type/bugfix This PR fixes a bug. labels Nov 11, 2019
@crazycs520
Copy link
Contributor Author

/run-all-tests

@codecov
Copy link

codecov bot commented Nov 11, 2019

Codecov Report

Merging #13339 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #13339        +/-   ##
================================================
- Coverage   80.2109%   80.1109%   -0.1001%     
================================================
  Files           469        469                
  Lines        112340     112162       -178     
================================================
- Hits          90109      89854       -255     
- Misses        15277      15332        +55     
- Partials       6954       6976        +22

tangenta
tangenta reviewed Nov 11, 2019
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangenta tangenta added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 11, 2019
zimulala
zimulala reviewed Nov 11, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 11, 2019
djshow832
djshow832 reviewed Nov 11, 2019
View reviewed changes
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djshow832 djshow832 added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Nov 11, 2019
@bb7133 bb7133 merged commit bcad464 into pingcap:master Nov 11, 2019
@sre-bot sre-bot mentioned this pull request Nov 11, 2019
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Nov 11, 2019

cherry pick to release-2.1 in PR #13345

@sre-bot sre-bot mentioned this pull request Nov 11, 2019
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Nov 11, 2019

cherry pick to release-3.0 in PR #13346

@sre-bot sre-bot mentioned this pull request Nov 11, 2019
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Nov 11, 2019

cherry pick to release-3.1 in PR #13347

@djshow832 djshow832 added the status/can-merge Indicates a PR has been approved by a committer. label Nov 11, 2019
zimulala pushed a commit that referenced this pull request Nov 13, 2019
@sre-bot @zimulala
ddl: check table name length when rename table (#13339) (#13347)
57198a5
zimulala pushed a commit that referenced this pull request Nov 13, 2019
@sre-bot @zimulala
ddl: check table name length when rename table (#13339) (#13346)
733824f
winkyao pushed a commit that referenced this pull request Nov 13, 2019
@sre-bot @winkyao
ddl: check table name length when rename table (#13339) (#13345)
dc7a200
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@crazycs520 @XiaTianliang
ddl: check table name length when rename table (pingcap#13339)
96a055d
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 left review comments

@zimulala zimulala zimulala left review comments

@tangenta tangenta tangenta approved these changes

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@crazycs520 @sre-bot @zimulala @tangenta @djshow832 @bb7133 @you06