expression: implement vectorized evaluation for builtinCurrentRoleSig
#13352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
qw4990 and
SunRunAway
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #13352 +/- ##
===========================================
Coverage 80.1859% 80.1859%
===========================================
Files 469 469
Lines 112526 112526
===========================================
Hits 90230 90230
Misses 15308 15308
Partials 6988 6988 |
SunRunAway
reviewed
Nov 11, 2019
expression/builtin_info_vec.go
Outdated
Comment on lines
135
to
140
| for i, r := range sortedRes { | ||
| res += r | ||
| if i != len(data.ActiveRoles)-1 { | ||
| res += "," | ||
| } | ||
| } |
There was a problem hiding this comment.
Are these code equal to strings.Join?
Reminiscent
added
status/can-merge
|
/run-all-tests |
|
@shihongzhi merge failed. |
|
�/rebuild |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
implement vectorized evaluation for builtinCurrentRoleSig , for #12106
What is changed and how it works?
Tests