expression: fix panic while call Column.VecEvalInt
#13401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lonng <heng@lonng.org>
ghost
requested review from
qw4990 and
SunRunAway
and removed request for
a team
Signed-off-by: Lonng <heng@lonng.org>
SunRunAway
reviewed
Nov 12, 2019
expression/column_test.go
Outdated
| @@ -172,7 +172,7 @@ func (s *testEvaluatorSuite) TestColHybird(c *C) { | |||
| c.Assert(err, IsNil) | |||
| input.AppendBytes(0, num) | |||
| } | |||
| result, err := newBuffer(types.ETInt, 1024) | |||
| result, err := newBuffer(types.ETString, 1024) | |||
There was a problem hiding this comment.
Could you add an annotation to explain why use VecEvalInt but type is ETString here?
There was a problem hiding this comment.
Maybe we should keep this regular test and add a new specific case.
There was a problem hiding this comment.
The case can be triggered if the result chunk.Chunk has a different field type with Int.
There was a problem hiding this comment.
I get it, but it is not intuitive for the first-time code reader.
Codecov Report
@@ Coverage Diff @@
## master #13401 +/- ##
===========================================
Coverage 80.2116% 80.2116%
===========================================
Files 471 471
Lines 113324 113324
===========================================
Hits 90899 90899
Misses 15369 15369
Partials 7056 7056 |
Signed-off-by: Lonng <heng@lonng.org>
|
/run-integration-copr-test copr-test=pr/22 |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@lonng merge failed. |
|
/run-integration-ddl-test |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Signed-off-by: Lonng <heng@lonng.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lonng heng@lonng.org
What problem does this PR solve?
expression: fix panic while call
Column.VecEvalIntWhat is changed and how it works?
The
Column.VecEvalInttreats thechunk.Chunkas anint64container, but the originalchunk.Chunkmay have a different field type.Check List
Tests
Release note.