-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: implement vectorized evaluation for builtinCastStringAsRealSig
#13445
expression: implement vectorized evaluation for builtinCastStringAsRealSig
#13445
Conversation
Thanks for your contribution. If your PR get merged, you will be rewarded 50 points. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e4c445c
to
7a422cf
Compare
Codecov Report
@@ Coverage Diff @@
## master #13445 +/- ##
===========================================
Coverage 80.3183% 80.3183%
===========================================
Files 472 472
Lines 114894 114894
===========================================
Hits 92281 92281
Misses 15407 15407
Partials 7206 7206 |
/rebuild |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, WELL DONE!
Your auto merge job has been accepted, waiting for 13402 |
/run-all-tests |
@pingyu merge failed. |
…tringAsRealSig` (pingcap#13445)" This reverts commit 0b41fe9.
PCP #12105
What problem does this PR solve?
Implement vectorized evaluation for builtinCastStringAsRealSig at #12105
What is changed and how it works?
It gets faster about 20%.
Check List
Tests