Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner/core: add a range check against display width of BIT column type (#11942) #13511

Merged
merged 2 commits into from
Nov 18, 2019

Conversation

tangenta
Copy link
Contributor

Cherry-pick #11942.

@tangenta
Copy link
Contributor Author

/run-unit-test

Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. labels Nov 18, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 18, 2019

Your auto merge job has been accepted, waiting for 13512

@sre-bot
Copy link
Contributor

sre-bot commented Nov 18, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 18, 2019

@tangenta merge failed.

@tangenta
Copy link
Contributor Author

/run-unit-test

1 similar comment
@tangenta
Copy link
Contributor Author

/run-unit-test

@tangenta tangenta added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Nov 18, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 18, 2019

Sorry @tangenta, you don't have permission to trigger auto merge event on this branch.

@tangenta tangenta removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 18, 2019
@zimulala zimulala added the status/can-merge Indicates a PR has been approved by a committer. label Nov 18, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 18, 2019

/run-all-tests

@sre-bot sre-bot merged commit fc1824c into pingcap:release-2.1 Nov 18, 2019
tangenta added a commit to tangenta/tidb that referenced this pull request Nov 19, 2019
sre-bot pushed a commit that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants