Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression:implement vectorized evaluation for builtinConvertSig #13537

Merged
merged 12 commits into from
Nov 27, 2019

Conversation

icditwang
Copy link
Contributor

@icditwang icditwang commented Nov 18, 2019

PCP #12106

What problem does this PR solve?

implement vectorized evaluation for builtinConvertSig

What is changed and how it works?

BenchmarkVectorizedBuiltinStringFunc/builtinConvertSig-VecBuiltinFunc-8         	    6200	    181291 ns/op	  239954 B/op	    1668 allocs/op
BenchmarkVectorizedBuiltinStringFunc/builtinConvertSig-NonVecBuiltinFunc-8      	    3864	    315941 ns/op	  279890 B/op	    3332 allocs/op

Check List

Tests

  • Unit test

@icditwang icditwang requested a review from a team as a code owner November 18, 2019 06:30
@sre-bot
Copy link
Contributor

sre-bot commented Nov 18, 2019

Thanks for your contribution. If your PR get merged, you will be rewarded 50 points.

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 18, 2019
@ghost ghost requested review from SunRunAway and XuHuaiyu and removed request for a team November 18, 2019 06:30
@breezewish
Copy link
Member

/run-integration-copr-test

2 similar comments
@breezewish
Copy link
Member

/run-integration-copr-test

@breezewish
Copy link
Member

/run-integration-copr-test

@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #13537 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13537   +/-   ##
===========================================
  Coverage   80.2638%   80.2638%           
===========================================
  Files           474        474           
  Lines        117586     117586           
===========================================
  Hits          94379      94379           
  Misses        15800      15800           
  Partials       7407       7407

Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/LGT1 Indicates that a PR has LGTM 1. and removed status/ReqChange labels Nov 21, 2019
@qw4990 qw4990 requested a review from XuHuaiyu November 21, 2019 07:55
@SunRunAway SunRunAway removed their request for review November 25, 2019 10:24
@qw4990 qw4990 requested a review from Reminiscent November 26, 2019 08:23
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 27, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 27, 2019

/run-all-tests

@sre-bot sre-bot merged commit 0fcf1df into pingcap:master Nov 27, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 27, 2019

@icditwang complete task #12106 and get 50 score, currerent score 450.

@sre-bot
Copy link
Contributor

sre-bot commented Nov 27, 2019

Congratulations, you get 650 score from easy level tasks in PCP-1, try some medium and hard tasks!(you can not reward from easy and vector tasks now)

@icditwang icditwang deleted the builtinConvertSig branch November 27, 2019 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants