Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: format error code for memory package #13540

Merged
merged 4 commits into from
Nov 22, 2019
Merged

util: format error code for memory package #13540

merged 4 commits into from
Nov 22, 2019

Conversation

imtbkcat
Copy link

What problem does this PR solve?

Error code in util/memory package is uneffective. It will show default error code 1105 when error occur.

What is changed and how it works?

Init error code for util/memory package and add yesy.

Check List

Tests

  • Unit test

Code changes

  • None

Side effects

  • None

Related changes

  • Need to cherry-pick to the release branch

@imtbkcat imtbkcat added the type/enhancement The issue or PR belongs to an enhancement. label Nov 18, 2019
jackysp
jackysp reviewed Nov 18, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 18, 2019
@codecov
Copy link

codecov bot commented Nov 18, 2019 •
edited
Loading

Codecov Report

Merging #13540 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master    #13540   +/-   ##
=========================================
  Coverage   79.944%   79.944%           
=========================================
  Files          473       473           
  Lines       116200    116200           
=========================================
  Hits         92895     92895           
  Misses       15979     15979           
  Partials      7326      7326

lysu
lysu approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 19, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 19, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 19, 2019

@imtbkcat merge failed.

@jackysp
Copy link
Member

jackysp commented Nov 22, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Nov 22, 2019

Your auto merge job has been accepted, waiting for 13544

@sre-bot
Copy link
Contributor

sre-bot commented Nov 22, 2019

/run-all-tests

@sre-bot sre-bot merged commit 49ad436 into pingcap:master Nov 22, 2019
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@XiaTianliang
util: format error code for memory package (pingcap#13540)
d600361
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@lysu lysu lysu approved these changes

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imtbkcat @sre-bot @jackysp @lysu