Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: show max-proc-keys and p95-proc-keys in results of explain analyze #13692

Merged
merged 8 commits into from
Nov 27, 2019
Merged

executor: show max-proc-keys and p95-proc-keys in results of explain analyze #13692

merged 8 commits into from
Nov 27, 2019

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Nov 22, 2019

What problem does this PR solve?

Show max-proc-keys and p95-proc-keys in the results of explain analyze, which can help us to check if there are hot regions.

After this PR:

| └─TableReader_17       | 1.00  | root      | data:StreamAgg_8                                           | time:247.008µs, loops:200, rows:201010, rpc time:183.957µs, proc keys max:101010, p95:2000   | 137 Bytes |

Check List

Tests

  • Unit test

@qw4990 qw4990 added the sig/execution SIG execution label Nov 22, 2019
@qw4990 qw4990 requested review from lzmhhh123, zz-jason and wshwsh12 and removed request for lzmhhh123 November 22, 2019 08:30
lzmhhh123
lzmhhh123 reviewed Nov 25, 2019
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the explain tests? Others are looked good to me.

@codecov
Copy link

codecov bot commented Nov 26, 2019 •
edited
Loading

Codecov Report

Merging #13692 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13692   +/-   ##
===========================================
  Coverage   80.1681%   80.1681%           
===========================================
  Files           474        474           
  Lines        116898     116898           
===========================================
  Hits          93715      93715           
  Misses        15810      15810           
  Partials       7373       7373

@qw4990
Copy link
Contributor Author

qw4990 commented Nov 26, 2019

/run-all-tests

@qw4990
Copy link
Contributor Author

qw4990 commented Nov 26, 2019

Fix the explain tests? Others are looked good to me.

Fixed, PTAL~ @lzmhhh123

lzmhhh123
lzmhhh123 reviewed Nov 26, 2019
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzmhhh123 lzmhhh123 added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 26, 2019
@qw4990 qw4990 requested a review from Reminiscent November 26, 2019 06:29
wshwsh12
wshwsh12 approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wshwsh12 wshwsh12 added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 27, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 27, 2019

/run-all-tests

@sre-bot sre-bot merged commit e4bdb7b into pingcap:master Nov 27, 2019
qw4990 added a commit to qw4990/tidb that referenced this pull request Nov 27, 2019
@qw4990
executor: show max-proc-keys and p95-proc-keys in results of `exp…
a050324 
…lain analyze` (pingcap#13692)
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@qw4990 @XiaTianliang
executor: show max-proc-keys and p95-proc-keys in results of `exp…
dd84eb5 
…lain analyze` (pingcap#13692)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 left review comments

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@zz-jason zz-jason Awaiting requested review from zz-jason

@Reminiscent Reminiscent Awaiting requested review from Reminiscent

Assignees
No one assigned
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qw4990 @sre-bot @wshwsh12 @lzmhhh123