Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: move the success message from explaintest to test #13748

Merged
merged 4 commits into from
Nov 27, 2019
Merged

Makefile: move the success message from explaintest to test #13748

merged 4 commits into from
Nov 27, 2019

Conversation

tangenta
Copy link
Contributor

What problem does this PR solve?

Fix #13747.

What is changed and how it works?

move the success message from explaintest to test.

Check List

Tests

  • Manual test

Code changes

N/A

Side effects

N/A

Related changes

N/A

Release note

N/A

@sre-bot
Copy link
Contributor

sre-bot commented Nov 26, 2019

Thanks for your PR.
This PR will be closed by bot because you already had 3 opened PRs, close or merge them before submitting a new one.
#13127 , #13727 , #13744

@sre-bot sre-bot closed this Nov 26, 2019
@tangenta tangenta reopened this Nov 26, 2019
@codecov
Copy link

codecov bot commented Nov 26, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@37ea7d4). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13748   +/-   ##
===========================================
  Coverage          ?   80.0896%           
===========================================
  Files             ?        474           
  Lines             ?     117140           
  Branches          ?          0           
===========================================
  Hits              ?      93817           
  Misses            ?      15928           
  Partials          ?       7395

djshow832
djshow832 reviewed Nov 27, 2019
View reviewed changes
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djshow832 djshow832 added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 27, 2019
@ngaut ngaut added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 27, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 27, 2019

/run-all-tests

@ngaut ngaut merged commit 17fe696 into pingcap:master Nov 27, 2019
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@tangenta @XiaTianliang
Makefile: move the success message from explaintest to test (pingcap#…
786a9da 
…13748)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 left review comments

@ngaut ngaut ngaut approved these changes

Assignees
No one assigned
Labels
component/test status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make report error when 'all test passed'
4 participants
@tangenta @sre-bot @ngaut @djshow832