Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: Fix potential timezone related bugs caused by gotime.Local #13833

Merged
merged 16 commits into from
Dec 20, 2019
Merged

types: Fix potential timezone related bugs caused by gotime.Local #13833

merged 16 commits into from
Dec 20, 2019

Conversation

Rustin170506
Copy link
Member

What problem does this PR solve?

#13626

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

None

Side effects

None

Related changes

None

Release note

None

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 30, 2019
@Rustin170506
Copy link
Member Author

@sre-bot /run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Dec 1, 2019

/ /run-all-tests

@codecov
Copy link

codecov bot commented Dec 1, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@76a8d08). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13833   +/-   ##
===========================================
  Coverage          ?   80.3618%           
===========================================
  Files             ?        480           
  Lines             ?     121310           
  Branches          ?          0           
===========================================
  Hits              ?      97487           
  Misses            ?      16094           
  Partials          ?       7729

@Rustin170506
Copy link
Member Author

PTAL~

tiancaiamao
tiancaiamao reviewed Dec 2, 2019
View reviewed changes
server/util_test.go Outdated Show resolved Hide resolved
server/util_test.go Outdated Show resolved Hide resolved
types/time.go Outdated Show resolved Hide resolved
types/time.go Show resolved Hide resolved
lysu
lysu reviewed Dec 2, 2019
View reviewed changes
types/time.go Outdated Show resolved Hide resolved
bb7133
bb7133 reviewed Dec 6, 2019
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Please address the comments.

@Rustin170506 Rustin170506 force-pushed the rustin-patch-local-time branch from f907c90 to 4bbf6ce Compare December 6, 2019 12:11
@Rustin170506
Copy link
Member Author

PTAL~

bb7133
bb7133 reviewed Dec 9, 2019
View reviewed changes
types/time_test.go Outdated Show resolved Hide resolved
util/codec/codec_test.go Outdated Show resolved Hide resolved
@tiancaiamao
Copy link
Contributor

LGTM
/run-all-tests

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 9, 2019
@Rustin170506
Copy link
Member Author

ping~

@tiancaiamao
Copy link
Contributor

PTAL @lysu @bb7133

1 similar comment
@Rustin170506
Copy link
Member Author

PTAL @lysu @bb7133

@Rustin170506
Copy link
Member Author

ping~

@Rustin170506
Copy link
Member Author

@ngaut Hi, Could you please help review this pr? Thank you very much.

bb7133
bb7133 approved these changes Dec 20, 2019
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 20, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 20, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Dec 20, 2019

@Rustin-Liu merge failed.

@Rustin170506
Copy link
Member Author

@sre-bot /merge

@sre-bot
Copy link
Contributor

sre-bot commented Dec 20, 2019

@Rustin-Liu No command or invalid command

@Rustin170506
Copy link
Member Author

@sre-bot /run-auto-merge//merge

@sre-bot
Copy link
Contributor

sre-bot commented Dec 20, 2019

@Rustin-Liu No command or invalid command

@Rustin170506
Copy link
Member Author

@sre-bot /run-auto-merge

@sre-bot
Copy link
Contributor

sre-bot commented Dec 20, 2019

@Rustin-Liu No command or invalid command

@lysu
Copy link
Contributor

lysu commented Dec 20, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Dec 20, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Dec 20, 2019

@Rustin-Liu merge failed.

@lysu
Copy link
Contributor

lysu commented Dec 20, 2019

/run-integration-copr-test

@lysu
Copy link
Contributor

lysu commented Dec 20, 2019

/run-integration-copr-test

@lysu
Copy link
Contributor

lysu commented Dec 20, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Dec 20, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Dec 20, 2019

@Rustin-Liu merge failed.

@lysu lysu merged commit 4d4678a into pingcap:master Dec 20, 2019
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@Rustin170506 @XiaTianliang
types: Fix potential timezone related bugs caused by gotime.Local (p…
87c2495 
…ingcap#13833)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysu lysu lysu left review comments

@tiancaiamao tiancaiamao tiancaiamao left review comments

@bb7133 bb7133 bb7133 approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Rustin170506 @sre-bot @tiancaiamao @lysu @bb7133