executor: trace the memory usage of Selection executors #13927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13927 +/- ##
===========================================
Coverage ? 80.2661%
===========================================
Files ? 483
Lines ? 121608
Branches ? 0
===========================================
Hits ? 97610
Misses ? 16273
Partials ? 7725 |
|
/run-all-tests |
|
/run-unit-test |
1 similar comment
|
/run-unit-test |
|
All comments have been addressed, PTAL @SunRunAway @ichn-hu |
|
@SunRunAway, @XuHuaiyu, @wshwsh12, @ichn-hu, PTAL. |
|
LGTM, I guess I could borrow your test in my HashAgg memtracker! |
ichn-hu
approved these changes
Dec 20, 2019
ichn-hu
added
the
status/can-merge
|
/run-all-tests |
|
@qw4990 merge failed. |
|
@SunRunAway, @ichn-hu, @XuHuaiyu, @wshwsh12, PTAL. |
|
/run-all-tests |
|
/run-all-tests |
|
/run-unit-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Trace the memory usage of Selection executors and display the result in
Explain Analyze.Wait for #13914.
What is changed and how it works?
Introduce a
memtrackerintoSelectionExecand use it to trace the memory usage.Check List
Tests