planner/cascades: support outer join implementation and push down selection for outer join #13996
Conversation
ghost
requested review from
francis0407 and
alivxxx
and removed request for
a team
| "SQL": "select t2.a, t2.b from t1 right join t2 on t1.a = t2.a where t1.a > 2 and t2.b > 200", | ||
| "Plan": [ | ||
| "Projection_12 10000.00 root test.t2.a, test.t2.b", | ||
| "└─HashRightJoin_14 10000.00 root right outer join, inner:TableReader_17 (REVERSED), equal:[eq(test.t1.a, test.t2.a)]", |
Codecov Report
@@ Coverage Diff @@
## master #13996 +/- ##
===========================================
Coverage ? 80.2254%
===========================================
Files ? 484
Lines ? 121707
Branches ? 0
===========================================
Hits ? 97640
Misses ? 16322
Partials ? 7745 |
planner/core/logical_plans.go
Outdated
| @@ -320,6 +322,9 @@ type LogicalSelection struct { | |||
| // but after we converted to CNF(Conjunctive normal form), it can be | |||
| // split into a list of AND conditions. | |||
| Conditions []expression.Expression | |||
| // HasBeenPushed means whether the selection is applied rule `PushSelDown`, | |||
| // it's used in cascades planner. | |||
| HasBeenPushed bool | |||
There was a problem hiding this comment.
We need a general solution to solve the recursive rule applying. There's also other cases that would cause endless loop.
You can add a TODO here first.
There was a problem hiding this comment.
This will be done by AppliedRuleSet. When we apply the rule PushSelDownJoin, we should add this rule to AppliedRuleSet of the new created Selection, so that the new Selection will not match this rule again.
There was a problem hiding this comment.
Where is the AppliedRuleSet?
There was a problem hiding this comment.
I'm still working on it >.<
There was a problem hiding this comment.
OK...Don't forget to remove this when you finish it. 0.0
|
The field |
That's alright. Go ahead. |
|
/run-unit-test |
lzmhhh123
added
the
status/can-merge
|
/run-all-tests |
|
@lzmhhh123 merge failed. |
|
/run-integration-copr-test |
|
/merge |
|
/run-all-tests |
What problem does this PR solve?
As the title says.
What is changed and how it works?
support outer join implementation rule and push down selection for outer join
Check List
Tests
Code changes