Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errcode: add errcode for structure, tablecodec, admin file #14054

Merged
merged 4 commits into from
Dec 16, 2019

Conversation

cfzjywxk
Copy link
Contributor

What problem does this PR solve?

Add error codes, parser pull request

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note

@cfzjywxk cfzjywxk requested a review from a team as a code owner December 13, 2019 10:54
@ghost ghost requested review from alivxxx and lzmhhh123 and removed request for a team December 13, 2019 10:54
@cfzjywxk
Copy link
Contributor Author

@jackysp @imtbkcat PTAL

@codecov
Copy link

codecov bot commented Dec 16, 2019

Codecov Report

Merging #14054 into master will decrease coverage by 0.1147%.
The diff coverage is 88.2352%.

@@               Coverage Diff                @@
##             master     #14054        +/-   ##
================================================
- Coverage   80.2661%   80.1513%   -0.1148%     
================================================
  Files           483        483                
  Lines        121608     121207       -401     
================================================
- Hits          97610      97149       -461     
- Misses        16273      16318        +45     
- Partials       7725       7740        +15

@cfzjywxk
Copy link
Contributor Author

/run-all-tests

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 16, 2019
@jackysp
Copy link
Member

jackysp commented Dec 16, 2019

PTAL @imtbkcat

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 16, 2019
@tiancaiamao tiancaiamao merged commit cbf7415 into pingcap:master Dec 16, 2019
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/server status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants