planner/cascades: Add ImplementationRule for Window #14085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
alivxxx and
winoros
and removed request for
a team
edytagarbarz
commented
Dec 16, 2019
| } | ||
|
|
||
| // CalcCost implements Implementation CalcCost interface. | ||
| func (impl *WindowImpl) CalcCost(outCount float64, children ...memo.Implementation) float64 { |
There was a problem hiding this comment.
Consulted with @francis0407 . The Window cost is not included in the old planner and this is to be fixed later.
zz-jason
added
sig/planner
francis0407
reviewed
Dec 17, 2019
48 tasks
Codecov Report
@@ Coverage Diff @@
## master #14085 +/- ##
===========================================
Coverage ? 80.1752%
===========================================
Files ? 483
Lines ? 121510
Branches ? 0
===========================================
Hits ? 97421
Misses ? 16334
Partials ? 7755 |
francis0407
reviewed
Dec 17, 2019
| var byItems []property.Item | ||
| byItems = append(byItems, lw.PartitionBy...) | ||
| byItems = append(byItems, lw.OrderBy...) | ||
| childProperty := &property.PhysicalProperty{ExpectedCnt: math.MaxFloat64, Items: byItems} |
There was a problem hiding this comment.
ExpectedCnt is also unused here, you can remove it.
winoros
approved these changes
Dec 18, 2019
alivxxx
added
the
status/can-merge
|
/run-all-tests |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Part of #13709
Add ImplementationRule for Window