Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: check foreign key constraint when drop,modify,change column (#14043) #14162

Merged
merged 2 commits into from
Dec 20, 2019

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

cherry-pick #14043

parser pingcap/parser#695

@crazycs520 crazycs520 added type/bugfix This PR fixes a bug. priority/release-blocker This issue blocks a release. Please solve it ASAP. type/2.1 cherry-pick labels Dec 20, 2019
@crazycs520
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 20, 2019
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix CI.
Rest LGTM.

@crazycs520
Copy link
Contributor Author

/run-all-tests

@zimulala zimulala added the status/can-merge Indicates a PR has been approved by a committer. label Dec 20, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 20, 2019

Your auto merge job has been accepted, waiting for 14141

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 20, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 20, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Dec 20, 2019

@crazycs520 merge failed.

@crazycs520
Copy link
Contributor Author

/run-unit-test

3 similar comments
@crazycs520
Copy link
Contributor Author

/run-unit-test

@zimulala
Copy link
Contributor

/run-unit-test

@zimulala
Copy link
Contributor

/run-unit-test

@zimulala
Copy link
Contributor

/run-unit-test

1 similar comment
@zimulala
Copy link
Contributor

/run-unit-test

@zimulala zimulala merged commit fcbcc45 into pingcap:release-2.1 Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants