bindinfo: fix bugs when using bindings #14263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eurekaka
reviewed
Jan 14, 2020
| func (e *SQLBindExec) createSQLBind(ctx context.Context) error { | ||
| sqlExec := e.ctx.(sqlexec.SQLExecutor) | ||
| // Use explain to check the validity of bind sql. | ||
| recordSets, err := sqlExec.Execute(ctx, fmt.Sprintf("explain %s", e.bindSQL)) |
There was a problem hiding this comment.
explain is much more expensive than parsing and plan building?
There was a problem hiding this comment.
Yes, but it much more easier by using explain, and it could also check the privilege of select tables.
|
/merge |
sre-bot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for 14470 |
|
/run-all-tests |
|
/merge |
|
/run-all-tests |
|
@lamxTyler merge failed. |
|
/run-unit-test |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
>= 10, but latter the query was>= -1, tidb will panic when binding hints.What is changed and how it works?
Check List
Tests
Unit test
Code changes
Has exported function/method change
Side effects
Related changes
Release note