Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner/cascades: add transformation rule PushLimitDownUnionAll. #14264

Merged
merged 6 commits into from
Dec 28, 2019

Conversation

doggeral
Copy link
Contributor

What problem does this PR solve?

This PR adds Transformation rule which pushes the limit down to unionall.
refer to: #13709

What is changed and how it works?

The logic is the same as pushdownTopN.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

@doggeral doggeral requested a review from a team as a code owner December 27, 2019 08:26
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 27, 2019
@ghost ghost requested review from francis0407 and alivxxx and removed request for a team December 27, 2019 08:26
@francis0407 francis0407 added the sig/planner SIG: Planner label Dec 27, 2019
@francis0407 francis0407 changed the title Add transformation rule PushLimitDownUnionAll. planner/cascades: add transformation rule PushLimitDownUnionAll. Dec 27, 2019
Copy link
Member

@francis0407 francis0407 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francis0407 francis0407 added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 28, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 28, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 28, 2019

Your auto merge job has been accepted, waiting for 14206

@sre-bot
Copy link
Contributor

sre-bot commented Dec 28, 2019

/run-all-tests

@sre-bot sre-bot merged commit a5c4606 into pingcap:master Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants